-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bottom actions button colors for themes #2075
Conversation
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/12992463088/artifacts/2491438231 |
Here is how it looks for Erlang, a bit weird I think: ![]() cc @garazdawi |
I suppose the red border is the issue here |
@hichemfantar we could try one with the border in the same but that may be too different from the theme. Btw, you can generate the Erlang version with |
i think it's good now |
Here are the new versions. Erlang![]() Elixir![]() I am fine with both current and this PR, so I am glad to listen to @garazdawi's and @DavidOliver's preferences too. |
lgtm |
LGTM, too, if we're not using red for Erlang's inner content links. I agree it's best to keep the red and blue away from each other in this case. Thanks! |
I don’t have a preference, go with whichever you think works best. |
@DavidOliver I know you said it looks good to you but do you prefer this one? |
@josevalim, I prefer it to combining a red outline and blue link text. Is that what you mean? |
If you prefer the one currently in main or this one. :) |
@josevalim, sorry. 😄 I prefer this one, with the page title in the language colour. |
💚 💙 💜 💛 ❤️ |
Adjust colors for bottom action buttons to improve visibility and consistency across dark and light themes.